Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorials/jokes): update code highlight lines #2404

Closed
wants to merge 2 commits into from

Conversation

ChenxiiCheng
Copy link

@ChenxiiCheng ChenxiiCheng commented Mar 19, 2022

  • Docs
  • Tests

Looks like there is one place where the code highlighting is incorrect

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 19, 2022

Hi @ChenxiiCheng,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 19, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@machour
Copy link
Collaborator

machour commented Mar 20, 2022

Thank you for taking the time for this PR. 🙏🏼
This issue (and others) are already addressed in #2395 that's getting merged soon

@machour machour closed this Mar 20, 2022
@machour machour added duplicate This issue or pull request already exists docs labels Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed docs duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants